It is currently Tue, 17 May 2022 02:11:39 GMT



 
Author Message
 Patch: linux-2.5.2-pre8/drivers/sound compilation fixes: MINOR-->minor

        Doing a global replace of "MINOR(" with "minor(" in all
.c files in linux/drivers/sound allows all of the sound drivers
to compile (at least as modules on x86).  This reflect the
changes in kdev_t introduced in linux-2.5.2-pre6.  You can do this
by applying the following patch *or* by the following shell command
(which is how I did it in the first place):

for file in $(find linux/drivers/sound -name '*.c' | xargs egrep -l 'MINOR\(' ) ; do
ed $file << DONE ; done
%s/MINOR(/minor(/g
DONE

        One note about this: this resulted in some drivers that
made the following rather obscure looking declarations:

        {
                int minor = minor(dev);
                ...
        }

        Apparently, the variable being declared is not in the scope
of its initialization value.  So, the code works, but it's not as
clear as could be.  I could rename the effected variables if need
be, although I that is something that individual device driver
maintainers could deal with at "leisure" just as well.

        I have not tested these changes.  I only know that they
make the sound drivers compile.

--
Adam J. Richter     __     ______________   4880 Stevens Creek Blvd, Suite 104
a...@yggdrasil.com     \ /                  San Jose, California 95129-1034
+1 408 261-6630         | g g d r a s i l   United States of America
fax +1 408 261-6631      "Free Software For The Rest Of Us."

  sound.diffs
11K Download


 Wed, 23 Jun 2004 20:00:12 GMT   
 Patch: linux-2.5.2-pre8/drivers/sound compilation fixes: MINOR-->minor

You did not change ymfpci, why? Linus fixed it already?

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



 Thu, 24 Jun 2004 04:40:06 GMT   
 Patch: linux-2.5.2-pre8/drivers/sound compilation fixes: MINOR-->minor

        linux-2.5.2-pre8/drivers/sound/ymfpci.c compiles without
errors or warnings, unmodified.

Adam J. Richter     __     ______________   4880 Stevens Creek Blvd, Suite 104
a...@yggdrasil.com     \ /                  San Jose, California 95129-1034
+1 408 261-6630         | g g d r a s i l   United States of America
fax +1 408 261-6631      "Free Software For The Rest Of Us."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



 Thu, 24 Jun 2004 07:50:10 GMT   
 
   [ 3 post ] 

Similar Threads

1. Patch: linux-2.5.2-pre8/drivers/ieee1394 kdev_t compilation fixes

2. Patch: linux-2.5.2-pre8/drivers/mtd compilation fixes

3. Patch: linux-2.5.2-pre8/drivers/md partial compilation fixes

4. Patch?: linux-2.5.2-pre8/drivers/video kdev_t compilation fixes

5. linux-2.5.2-pre8/drivers/telephony kdev_t compilation fixes

6. Minor fix for driver/serial/core.c

7. PCI Hotplug ACPI driver minor fix.

8. 2.5.18 : drivers/pci/pool.c minor printk fix

9. Minor fix for the via82cxxx.c IDE driver.

10. 'MINOR' fix in emu10k1 driver


 
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group.
Designed by ST Software